Fix shadow publishing of javaagent instrumentation #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
|
Hm, it's still not quite right, opentelemetry-javaagent and opentelemetry-armeria-shaded-for-testing do not publish javadoc or sources artifact.. |
|
ok I reverted and went with small fix, let's see how it goes... |
anuraaga
approved these changes
Jun 17, 2021
| @@ -8,7 +8,7 @@ plugins { | |||
| publishing { | |||
| publications { | |||
| register<MavenPublication>("maven") { | |||
| if (tasks.names.contains("shadowJar") && findProperty("noShadowPublish") != "true") { | |||
There was a problem hiding this comment.
Doh! Another motivation to move this and the other flags to the Java extension to make it typesafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the
-allartifact was being published:I don't completely understand it, but after a bunch of trial and error this change seems to be working.